On Wed, Jun 12, 2024 at 1:09 AM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote: > > Set -e to make these scripts fail on the first error. > > Set -u because these scripts are invoked by Makefile, and do not work > properly without necessary variables defined. > > Remove the explicit "test -n ..." from scripts/package/install-extmod-build. > > Both options are described in POSIX. [1] > > [1]: https://pubs.opengroup.org/onlinepubs/009604499/utilities/set.html > > Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx> > --- Setting -u needs more careful review and test. This patch will break 'make deb-pkg'. ./scripts/package/mkdebian: 150: KDEB_PKGVERSION: parameter not set To set -u, scripts/package/mkdebian needs code refactoring. I will keep scripts/package/mkdebian untouched. -- Best Regards Masahiro Yamada
