On Sat, Jun 1, 2024 at 2:49 AM John Hubbard <jhubbard@xxxxxxxxxx> wrote: > > 1) Provide a more self-explanatory error message for the "Rust not > available" case. Without this patch, if Rust is not set up properly > (which happens a lot, seeing as how one must routinely run "rustup > override ..." with each new kernel release), the "make rust-analyzer" > invocation generates a somewhat confusing message: > > "No rule to make target 'rust-analyzer" > > This is confusing at first, because there is, in fact, a rust-analyzer > build target. It's just not set up to handle errors gracefully. > > Instead of inflicting that on the developer, just print that Rust is > not available, with a blank line above and below, so it doesn't get lost > in the noise. Now the error case looks like this: > > $ make rust-analyzer > > Rust is not available > > make[1]: *** [/kernel_work/linux-github/Makefile:1975: rust-analyzer] Error 1 > make: *** [Makefile:240: __sub-make] Error 2 > > 2) As long as I'm there, also add some documentation about what > rust-analyzer provides. > > Signed-off-by: John Hubbard <jhubbard@xxxxxxxxxx> Reviewed-by: Alice Ryhl <aliceryhl@xxxxxxxxxx> Tested-by: Alice Ryhl <aliceryhl@xxxxxxxxxx>
