On Wed, Jun 12, 2024 at 6:19 AM kernel test robot <lkp@xxxxxxxxx> wrote: > > Hi Masahiro, > > kernel test robot noticed the following build warnings: > > [auto build test WARNING on masahiroy-kbuild/kbuild] > [also build test WARNING on masahiroy-kbuild/for-next next-20240611] > [cannot apply to masahiroy-kbuild/fixes linus/master v6.10-rc3] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/Masahiro-Yamada/kconfig-remove-unneeded-code-in-expr_compare_type/20240612-020202 > base: https://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git kbuild > patch link: https://lore.kernel.org/r/20240611175536.3518179-7-masahiroy%40kernel.org > patch subject: [PATCH 06/16] kconfig: refactor choice value calculation > reproduce: (https://download.01.org/0day-ci/archive/20240612/202406120445.P5QmPYgD-lkp@xxxxxxxxx/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot <lkp@xxxxxxxxx> > | Closes: https://lore.kernel.org/oe-kbuild-all/202406120445.P5QmPYgD-lkp@xxxxxxxxx/ > > All warnings (new ones prefixed by >>): > > >> scripts/kconfig/symbol.c:448:3: warning: label followed by a declaration is a C23 extension [-Wc23-extensions] > 448 | struct menu *choice_menu = sym_get_choice_menu(sym); > | ^ > 1 warning generated. > OK. I will move it to the top of the function. iff --git a/scripts/kconfig/symbol.c b/scripts/kconfig/symbol.c index b4d085342b94..063a478197e0 100644 --- a/scripts/kconfig/symbol.c +++ b/scripts/kconfig/symbol.c @@ -383,6 +383,7 @@ void sym_calc_value(struct symbol *sym) { struct symbol_value newval, oldval; struct property *prop; + struct menu *choice_menu; if (!sym) return; @@ -428,7 +429,7 @@ void sym_calc_value(struct symbol *sym) switch (sym_get_type(sym)) { case S_BOOLEAN: case S_TRISTATE: - struct menu *choice_menu = sym_get_choice_menu(sym); + choice_menu = sym_get_choice_menu(sym); if (choice_menu) { sym_calc_choice(choice_menu); -- Best Regards Masahiro Yamada
