Hi Chen-Yu,
On Tue, 21 May 2024 at 00:51, Chen-Yu Tsai <wenst@xxxxxxxxxxxx> wrote:
>
> According to the FIT image spec, the compatible string in the fdt image
Can you please add a link to where it says this in the spec? I cannot
find it after a short search.
I believe this patch is correct. Since the information is in the
configuration node it does not need to be in the FDT.
> node or any image node specifies the method to load the image, not the
> compatible string embedded in the FDT or used for matching.
>
> Drop the compatible string from the fdt image entry node.
>
> While at it also fix up a typo in the document section of output_dtb.
>
> Fixes: 7a23b027ec17 ("arm64: boot: Support Flat Image Tree")
> Signed-off-by: Chen-Yu Tsai <wenst@xxxxxxxxxxxx>
> ---
> scripts/make_fit.py | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/scripts/make_fit.py b/scripts/make_fit.py
> index 3de90c5a094b..263147df80a4 100755
> --- a/scripts/make_fit.py
> +++ b/scripts/make_fit.py
> @@ -190,7 +190,7 @@ def output_dtb(fsw, seq, fname, arch, compress):
> Args:
> fsw (libfdt.FdtSw): Object to use for writing
> seq (int): Sequence number (1 for first)
> - fmame (str): Filename containing the DTB
> + fname (str): Filename containing the DTB
> arch: FIT architecture, e.g. 'arm64'
> compress (str): Compressed algorithm, e.g. 'gzip'
>
> @@ -211,7 +211,6 @@ def output_dtb(fsw, seq, fname, arch, compress):
> fsw.property_string('type', 'flat_dt')
> fsw.property_string('arch', arch)
> fsw.property_string('compression', compress)
> - fsw.property('compatible', bytes(compat))
>
> with open(fname, 'rb') as inf:
> compressed = compress_data(inf, compress)
> --
> 2.45.0.215.g3402c0e53f-goog
>
Regards,
Simon
