On Tue, May 14, 2024 at 07:39:31AM +0900, Masahiro Yamada wrote: > On Tue, May 14, 2024 at 3:48 AM Kees Cook <keescook@xxxxxxxxxxxx> wrote: > > I am worried about the use of "guess" and "most", though. :) Before, we > > had some clear opt-out situations, and now it's more of a side-effect. I > > think this is okay, but I'd really like to know more about your testing. > > - defconfig for arc, hexagon, loongarch, microblaze, sh, xtensa > - allmodconfig for the other architectures > > (IIRC, allmodconfig failed for the first case, for reasons unrelated > to this patch set, so I used defconfig instead. > I do not remember what errors I observed) > > I checked the diff of .*.cmd files. Ah-ha, perfect! Thanks. :) > > Did you find any cases where you found that instrumentation was _removed_ > > where not expected? > > See the commit log of 1/3. Okay, thanks. I wasn't sure if that was the complete set or just part of the "most" bit. :) Thanks! I think this should all be fine. I'm not aware of anything melting down yet from these changes being in -next, so: Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx> -- Kees Cook
