On Tue, Apr 9, 2024, at 18:25, Nathan Chancellor wrote: > On Thu, Apr 04, 2024 at 05:16:54PM +0200, Arnd Bergmann wrote: >> From: Arnd Bergmann <arnd@xxxxxxxx> > > I have not done any LLVM builds with this change but if this is going to > be in -next for a little bit, we should be able to get any regressions > handled quickly. > > I am in favor of more warnings but I am a little nervous this will make > compiler upgrades (or tracking their mainline) even more difficult. I do > not have a feeling for how often warnings are added to -Wall and -Wextra > so this may be unfounded but the kernel's -Werror use complicates this > in my opinion. I can engage with the clang folks to try and be given a > heads up when a warning is going to be added to -Wextra, it would be > good to have someone do something similar for GCC, so that those > upgrades do not cause something like this change to be rolled back. My impression is that most new warnings get added to -Wall rather than -Wextra anyway. If they are added to -Wextra, it's still easy enough to turn them off individually unless W=1 is set. > It is easy enough to back out of this if necessary though, so: > > Acked-by: Nathan Chancellor <nathan@xxxxxxxxxx> Thanks! Arnd