Re: [PATCH] scripts/unifdef: avoid constexpr keyword

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 21, 2024 at 3:01 AM Arnd Bergmann <arnd@xxxxxxxxxx> wrote:
>
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> Starting with c23, 'constexpr' is a keyword in C like in C++ and cannot
> be used as an identifier:
>
> scripts/unifdef.c:206:25: error: 'constexpr' can only be used in variable declarations
>   206 | static bool             constexpr;              /* constant #if expression */
>       |                         ^
> scripts/unifdef.c:880:13: error: expected identifier or '('
>   880 |                 constexpr = false;
>       |                           ^
>
> Rename this instance to allow changing to C23 at some point in the future.
>
> Fixes: d8379ab1dde3 ("unifdef: update to upstream revision 1.190")

This can be a problem only for future kernels.
Is it worth adding Fixes?

Even if the kernel bumps to C23 at some point,
such a patch will not be backported.




-- 
Best Regards
Masahiro Yamada





[Index of Archives]     [Linux&nblp;USB Development]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite Secrets]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux