On Wed, 27 Mar 2024 at 00:34, Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx> wrote: > > > > On 3/26/2024 3:25 PM, Dmitry Baryshkov wrote: > > On Wed, 27 Mar 2024 at 00:19, Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx> wrote: > >> > >> > >> > >> On 3/22/2024 3:57 PM, Dmitry Baryshkov wrote: > >>> Import the gen_headers.py script from Mesa, commit FIXME. This script > >>> will be used to generate MSM register files on the fly during > >>> compilation. > >>> > >>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > >>> --- > >>> drivers/gpu/drm/msm/registers/gen_header.py | 957 ++++++++++++++++++++++++++++ > >>> 1 file changed, 957 insertions(+) > >>> > >>> diff --git a/drivers/gpu/drm/msm/registers/gen_header.py b/drivers/gpu/drm/msm/registers/gen_header.py > >>> new file mode 100644 > >>> index 000000000000..ae39b7e6cde8 > >>> --- /dev/null > >>> +++ b/drivers/gpu/drm/msm/registers/gen_header.py > >>> @@ -0,0 +1,957 @@ > >>> +#!/usr/bin/python3 > >>> + > >> > >> We need a licence and copyright here. > > > > Yes, this is going to be fixed in the next revision. Mesa already got > > the proper SPDX header here. > > > >> > >> Also is something like a "based on" applicable here? > >> > >> <snip> > >> > >>> +import xml.parsers.expat > >>> +import sys > >>> +import os > >>> +import collections > >>> +import argparse > >>> +import time > >>> +import datetime > >>> + > >>> +class Error(Exception): > >>> +This file was generated by the rules-ng-ng gen_header.py tool in this git repository: > >>> +http://gitlab.freedesktop.org/mesa/mesa/ > >>> +git clone https://gitlab.freedesktop.org/mesa/mesa.git > >>> + > >>> +The rules-ng-ng source files this header was generated from are: > >> > >> Is this still applicable ? > >> > >> Now gen_header.py is moved to kernel. > >> > > > > Copied, not moved. So Mesa remains the primary source for Adreno > > headers and gen_header.py > > > > But all future development and code review on gen_header.py will be done > in kernel itself OR periodically we will sync it up with mesa? We'd sync from kernel. -- With best wishes Dmitry
