On Mon, Mar 04, 2024 at 11:45:45AM -0800, Elliott Mitchell wrote:
> On Mon, Mar 04, 2024 at 10:50:49AM +0100, Nicolas Schier wrote:
> > On Fri, Mar 01, 2024 at 12:51:01PM -0800, Elliott Mitchell wrote:
> > > As $(abs_objtree) and $(abs_srctree) already exist, $(abspath )
> > > shouldn't be used with $(objtree) or $(srctree).
> > >
> > > Fixes: 0e1aa629f1ce ("kbuild: Do not clean resolve_btfids if the output does not exist")
> > > Signed-off-by: Elliott Mitchell <ehem+linux@xxxxxxx>
> > > ---
> > > I believe this is pretty much all fixes, but 0e1aa629f1ce was the most
> > > recent one.
> >
> > If you add a 'Fixes' trailer, please just include changes that fix that
> > commit. You're patch does much more than just modifying the changes
> > from commit 0e1aa629f1ce.
>
> Since all of these should have been used $(abs_srctree) or $(abs_objtree)
> when committed, all of these are fixes. Issue is most of them moved at
> least once, so tracking down the list is annoying.
>
> You consider ignoring this is fixing around 5-13 commits reasonable?
I think, fixing inconsistencies is a good thing, but I'm afraid it's
not always important enough to mark such changes as 'Fixes', as 'Fixes'
is especially used for auto-selecting patches for stable trees.
Kind regards,
Nicolas
