On Fri, Feb 23, 2024 at 2:08 AM Namhyung Kim <namhyung@xxxxxxxxxx> wrote: > > Hello, > > On Wed, Feb 21, 2024 at 5:42 AM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote: > > > > In Makefiles, $(error ), $(warning ), and $(info ) expand to the empty > > string, as explained in the GNU Make manual [1]: > > "The result of the expansion of this function is the empty string." > > > > Therefore, they are no-op except for logging purposes. > > > > $(shell ...) expands to the output of the command. It expands to the > > empty string when the command does not print anything to stdout. > > Hence, $(shell mkdir ...) is no-op except for creating the directory. > > > > Remove meaningless assignments. > > > > [1]: https://www.gnu.org/software/make/manual/make.html#Make-Control-Functions > > > > Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx> > > --- > > > > This is a treewide cleanup, but in practice, this is touching mostly > > perf Makefiles. I am sending this to perf subsystem. > > How do you want to route this? I can take it to perf tree if you're ok. Yes, that is my expectation because it will reduce the risk of merge conflicts. I only included the perf maintainers and ML to To:, and anything else in CC: -- Best Regards Masahiro Yamada
