On Tue, Jan 30, 2024 at 02:19:23PM -0800, William McVicker wrote: > On 01/29/2024, Nicolas Schier wrote: > > On Fri, Jan 12, 2024 at 02:19:46PM -0800, Will McVicker wrote: > > > Add an exception to the EMBEDDED_FILENAME warning for build files. This > > > > As far as I can see, your patch fixes only the checkpatch warnings for > > top-level Makefile and Kconfig (and leaving out top-level Kbuild). > > Other build files are not affected, right? > > Since $realfile includes the full path, I wasn't able to find a case where this > issue happens outside of the top-level build files. The same goes for Kbuild > files -- the top-level Kbuild file doesn't include other Kbuild files and the > other Kbuild files don't include other Kbuild files within the same directory. > If you prefer to protect against this warning in the future, I can include > Kbuild as well if you want. yes, I think it would be more complete if top-level Kbuild is also included. Could you also mention 'top-level' somewhere in the commit message? Thanks and kind regards, Nicolas
