On Wed, Jan 17, 2024 at 09:53:23AM -0300, Nícolas F. R. A. Prado wrote: > On Sun, Jan 14, 2024 at 07:08:13PM +0200, Andy Shevchenko wrote: > > On Thu, Jan 11, 2024 at 12:11:47PM -0300, Nícolas F. R. A. Prado wrote: > > > Generate aliases for coreboot modules to allow automatic module probing. ... > > > +/** > > > + * struct coreboot_device_id - Identifies a coreboot table entry > > > + * @tag: tag ID > > > + */ > > > +struct coreboot_device_id { > > > + __u32 tag; > > > +}; > > > > Don't you want to have a driver data or so associated with this? > > There's no need for it currently in any driver. This struct is being created > simply to allow auto modprobe. So it seems reasonable to leave it out and add it > later when/if needed. The problem is that you introduce a kinda ABI here, how do you handle this later? -- With Best Regards, Andy Shevchenko