On Wed, Jan 10, 2024 at 10:05 PM Tomasz Figa <tfiga@xxxxxxxxxxxx> wrote: > > On Fri, Dec 29, 2023 at 1:10 AM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote: > > > > On Thu, Dec 28, 2023 at 2:46 PM Tomasz Figa <tfiga@xxxxxxxxxxxx> wrote: > > > > > > When hidden options are toggled on (using 'z'), the number of options > > > on the screen can be overwhelming and may make it hard to distinguish > > > between available and hidden ones. Make them easier to distinguish by > > > displaying the hidden one as dim (using the A_DIM curses attribute). > > > > > > Signed-off-by: Tomasz Figa <tfiga@xxxxxxxxxxxx> > > > > > > > > Do you think this is useful? > > > > This changes the color only when you select a hidden item. > > > > > > For unselected items, you cannot distinguish hidden ones, > > as A_DIM has no effect to black text. > > > > > > Hmm, are you sure about that? For me it seems to dim the text. it > seems to be also used in the existing code for dlg.button_inactive.atr > of the mono theme: > > https://elixir.bootlin.com/linux/latest/source/scripts/kconfig/lxdialog/util.c#L26 Then, your code works only on the mono theme. (when your terminal does not support color, or "MENUCONFIG_COLOR=mono make menuconfig") In the normal color mode, the foreground text is black. (Just like a picture in https://en.wikipedia.org/wiki/Menuconfig) A_DIM does nothing for black. -- Best Regards Masahiro Yamada
