Hi Nathan, >On Tue, Dec 05, 2023 at 10:15:26AM +0800, Jialu Xu wrote: >> When symbolic links are involved in the path, os.path.abspath might not >> resolve the symlinks and instead return the absolute path with the >> symlinks intact. >> >> Use pathlib.Path resolve() instead of os.path.abspath() >> >> Signed-off-by: Jialu Xu <xujialu@xxxxxxxxx> > >Thanks for the clarification in your previous message [1], I suppose >that makes sense as to why nobody has reported this to us because that >is a rather odd situation that the upstream kernel would not experience. > >I think that some of those details should be in the commit message, >along with a short example like you provided, so that we know exactly >what the situation was and how this patch resolves it. > >Perhaps something like (please feel free to correct or reword as you >feel necessary): > >"When a path contains relative symbolic links, os.path.abspath() might >not follow the symlinks and instead return the absolute path with just >the relative paths resolved, resulting in an incorrect path. > ><broken example> > >Use pathlib.Path.resolve(), which resolves the symlinks and normalizes >the paths correctly. > ><working example>" > >The actual fix seems fine to me. Feel free to add > > Reviewed-by: Nathan Chancellor <nathan@xxxxxxxxxx> > >to the subsequent submission and please include both > > Masahiro Yamada <masahiroy@xxxxxxxxxx> > linux-kbuild@xxxxxxxxxxxxxxx > >on it in addition to the people you have here, as he is the one who >actually applies gen_compile_commands.py changes (I am going to send a >MAINTAINERS change for this). > >[1]: https://lore.kernel.org/20231205021523.4152128-1-xujialu@xxxxxxxxx/ > Thanks for the very detailed help! Patch update as v3. Cheers, Jialu
