Hi Masahiro, > On Tue, Nov 21, 2023 at 10:37 PM Petr Vorel <pvorel@xxxxxxx> wrote: > > Hi, > > I could have added some description, e.g. "shell variable $dirs is not used any > > more since 1fc9095846cc, therefore remove it". > > Please let me know if I should resent it as v2. > > Kind regards, > > Petr > > > Fixes: 1fc9095846cc ("kbuild: tar-pkg: use tar rules in scripts/Makefile.package") > > > Signed-off-by: Petr Vorel <pvorel@xxxxxxx> > I filled the commit log and fixed the commit subject > "kbuild: builddeb:" to "kbuild: buildtar:". Thanks for fixing this! Kind regards, Petr > Author: Petr Vorel <pvorel@xxxxxxx> > Date: Tue Nov 21 12:58:54 2023 +0100 > kbuild: buildtar: Remove unused $dirs > The shell variable $dirs is not used any more since 1fc9095846cc > ("kbuild: tar-pkg: use tar rules in scripts/Makefile.package"), > therefore remove it". > Fixes: 1fc9095846cc ("kbuild: tar-pkg: use tar rules in > scripts/Makefile.package") > Signed-off-by: Petr Vorel <pvorel@xxxxxxx> > Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx> > Thanks. > > > --- > > > scripts/package/buildtar | 2 -- > > > 1 file changed, 2 deletions(-) > > > diff --git a/scripts/package/buildtar b/scripts/package/buildtar > > > index 65b4ea502962..8ac075dd0e9c 100755 > > > --- a/scripts/package/buildtar > > > +++ b/scripts/package/buildtar > > > @@ -23,7 +23,6 @@ tmpdir=$1 > > > rm -rf -- "${tmpdir}" > > > mkdir -p -- "${tmpdir}/boot" > > > -dirs=boot > > > @@ -42,7 +41,6 @@ fi > > > if grep -q '^CONFIG_MODULES=y' include/config/auto.conf; then > > > make ARCH="${ARCH}" -f ${srctree}/Makefile INSTALL_MOD_PATH="${tmpdir}" modules_install > > > - dirs="$dirs lib" > > > fi