Hi Michael, On Fri, Nov 10, 2023 at 4:42 AM Michael Ellerman <mpe@xxxxxxxxxxxxxx> wrote: > kernel test robot <lkp@xxxxxxxxx> writes: > > kernel test robot noticed the following build errors: > > > > [auto build test ERROR on linus/master] > > [also build test ERROR on next-20231108] > > [cannot apply to v6.6] > > [If your patch is applied to the wrong git tree, kindly drop us a note. > > And when submitting patch, we suggest to use '--base' as documented in > > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > > > url: https://github.com/intel-lab-lkp/linux/commits/Arnd-Bergmann/ida-make-ida_dump-static/20231109-005742 > > base: linus/master > > patch link: https://lore.kernel.org/r/20231108125843.3806765-18-arnd%40kernel.org > > patch subject: [PATCH 17/22] powerpc: ps3: move udbg_shutdown_ps3gelic prototype > > config: powerpc64-randconfig-001-20231109 (https://download.01.org/0day-ci/archive/20231109/202311090843.b8ISrsV1-lkp@xxxxxxxxx/config) > > compiler: powerpc64-linux-gcc (GCC) 13.2.0 > > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231109/202311090843.b8ISrsV1-lkp@xxxxxxxxx/reproduce) > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > > the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot <lkp@xxxxxxxxx> > > | Closes: https://lore.kernel.org/oe-kbuild-all/202311090843.b8ISrsV1-lkp@xxxxxxxxx/ > > > > All errors (new ones prefixed by >>): > > > > arch/powerpc/platforms/ps3/gelic_udbg.c:59:1: warning: alignment 1 of 'struct debug_block' is less than 32 [-Wpacked-not-aligned] > > 59 | } __packed; > > | ^ > >>> arch/powerpc/platforms/ps3/gelic_udbg.c:240:6: error: redefinition of 'udbg_shutdown_ps3gelic' > > 240 | void udbg_shutdown_ps3gelic(void) > > | ^~~~~~~~~~~~~~~~~~~~~~ > > In file included from arch/powerpc/platforms/ps3/gelic_udbg.c:17: > > arch/powerpc/include/asm/ps3.h:520:20: note: previous definition of 'udbg_shutdown_ps3gelic' with type 'void(void)' > > 520 | static inline void udbg_shutdown_ps3gelic(void) {} > > | ^~~~~~~~~~~~~~~~~~~~~~ > > As pointed out by Arnd this is due to there being two symbols that > control the gelic_udbg.c code. > > I don't see the need for PS3GELIC_UDBG, without PPC_EARLY_DEBUG_PS3GELIC > it just causes gelic_udbg.c to be built, but never called. My first thought was: PPC_EARLY_DEBUG_PS3GELIC is meant as an early debugging console, while PS3GELIC_UDBG can be used with xmon later, but that does not seem to be the case. > The diff below fixes the error AFAICS. So your changes on top LGTM. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
