On Mon, Oct 16, 2023 at 11:25:44AM +0200, Arnd Bergmann wrote: > On Mon, Oct 9, 2023, at 12:30, Uwe Kleine-König wrote: > > On Mon, Oct 09, 2023 at 10:43:46AM +0200, Arnd Bergmann wrote: > > > > only a slight correction: As not having a remove callback can be fine > > and platform_remove() only calls .remove (or .remove_new) when non-NULL > > we're not hitting a NULL pointer dereference in the presence of > > > > .remove = __exit_p(somefunc), > > > > But a problem can arise later if some resource isn't properly freed and > > so it might be used at a later point in time which then most likely > > oopses. > > > > I didn't double check Arnd's list, but otherwise I agree to his > > analysis. > > Hi Uwe, > > Based on a few days of randconfig build testing, the patch > below addresses the remaining warnings I get for arm, arm64 and > x86 on linux-next. This is a shorter list than the ones that > I found in theory, possibly because some of the other ones > are only used in built-in code, or because they are never used > on these three architectures. > > Have you already sent patches for (some of) these? > > Arnd > > drivers/char/hw_random/mxc-rnga.c | 2 +- > drivers/gpu/drm/bridge/ti-tpd12s015.c | 4 ++-- > drivers/hwmon/smsc47m1.c | 2 +- > drivers/hwtracing/coresight/coresight-etm4x-core.c | 8 ++++---- > drivers/media/i2c/et8ek8/et8ek8_driver.c | 4 ++-- > drivers/memory/emif.c | 2 +- > drivers/mmc/host/davinci_mmc.c | 2 +- > drivers/mtd/nand/raw/txx9ndfmc.c | 2 +- The txx9ndfmc driver was fixed as part of this series, but Miquèl didn't take the patch, I guess because he wants it to be converted to module_platform_driver(). > drivers/pci/controller/dwc/pci-exynos.c | 4 ++-- > drivers/pci/controller/dwc/pcie-kirin.c | 4 ++-- These two drivers were already covered in 20231001170254.2506508-1-u.kleine-koenig@xxxxxxxxxxxxxx where I also addressed a similar problem in the keystone driver. > drivers/power/reset/at91-poweroff.c | 2 +- > drivers/power/reset/at91-reset.c | 2 +- > drivers/power/reset/at91-sama5d2_shdwc.c | 2 +- > drivers/rtc/rtc-at91rm9200.c | 2 +- > drivers/rtc/rtc-imxdi.c | 2 +- > drivers/rtc/rtc-mv.c | 2 +- > drivers/rtc/rtc-pxa.c | 2 +- > drivers/rtc/rtc-sh.c | 2 +- These rtc drivers are fixed in 20231002080529.2535610-1-u.kleine-koenig@xxxxxxxxxxxxxx > drivers/video/fbdev/atmel_lcdfb.c | 2 +- > drivers/video/fbdev/omap2/omapfb/displays/connector-analog-tv.c | 2 +- > drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c | 2 +- > drivers/video/fbdev/omap2/omapfb/displays/connector-hdmi.c | 2 +- > drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c | 2 +- > drivers/video/fbdev/omap2/omapfb/displays/encoder-tfp410.c | 2 +- > drivers/video/fbdev/omap2/omapfb/displays/encoder-tpd12s015.c | 2 +- > drivers/video/fbdev/omap2/omapfb/displays/panel-dpi.c | 2 +- > drivers/video/fbdev/omap2/omapfb/displays/panel-dsi-cm.c | 2 +- > .../video/fbdev/omap2/omapfb/displays/panel-sharp-ls037v7dw01.c | 2 +- > drivers/virt/coco/sev-guest/sev-guest.c | 2 +- > drivers/watchdog/at91sam9_wdt.c | 2 +- > sound/soc/codecs/tlv320adc3xxx.c | 4 ++-- I sent 20231004111624.2667753-1-u.kleine-koenig@xxxxxxxxxxxxxx to fix a/drivers/platform/x86/hp/hp-wmi.c, that's already applied so doesn't occur in your patch. The others I didn't address yet. I assume your question means you want to push that forward. That is very welcome, the I remove this from my todo list. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
