On Fri, Sep 29, 2023 at 5:29 AM Mauricio Faria de Oliveira <mfo@xxxxxxxxxxxxx> wrote: > > Without this 'else' statement, an "usb" name goes into two handlers: > the first/previous 'if' statement _AND_ the for-loop over 'devtable', > but the latter is useless as it has no 'usb' device_id entry anyway. > > Tested with allmodconfig before/after patch; no changes to *.mod.c: > > git checkout v6.6-rc3 > make -j$(nproc) allmodconfig > make -j$(nproc) olddefconfig > > make -j$(nproc) > find . -name '*.mod.c' | cpio -pd /tmp/before > > # apply patch > > make -j$(nproc) > find . -name '*.mod.c' | cpio -pd /tmp/after > > diff -r /tmp/before/ /tmp/after/ > # no difference > > Fixes: acbef7b76629 ("modpost: fix module autoloading for OF devices with generic compatible property") > Signed-off-by: Mauricio Faria de Oliveira <mfo@xxxxxxxxxxxxx> > --- Applied to linux-kbuild/fixes. Thanks. -- Best Regards Masahiro Yamada