On Sun, Aug 20, 2023 at 1:20 PM Sergey Senozhatsky <senozhatsky@xxxxxxxxxxxx> wrote: > > On (23/08/20 08:19), Masahiro Yamada wrote: > > > Example: > > > Suppose old .config has the following two options which > > > were removed from the recent kernel: > > > > > > $ cat .config > > > CONFIG_DISABLE_BUGS=y > > > > > > Running `make listunknownconfig` produces the following > > > list of unrecognized symbols: > > > > > > .config:6:warning: unknown symbol: DISABLE_BUGS > > > .config:7:warning: unknown unset symbol: ENABLE_WINAPI > > > > > > Signed-off-by: Sergey Senozhatsky <senozhatsky@xxxxxxxxxxxx> > > > > > > A new target is not what I like to see. > > > > > > We decided to add KCONFIG_VERBOSE, which will be used to > > warn options accidentally disabled or downgraded. > > That doesn't seem cover the cases that I'm concerned with. I don't see > anything related to "!sym" in the patch. > > What will KCONFIG_VERBOSE do if it reads the following config file? > > // assuming that both config options were valid and existed in the old > // kernel, but were removed/renamed in the new kernel > > $ cat .config > CONFIG_DISABLE_BUGS=y > # CONFIG_ENABLE_WINAPI is not set > > > I'd like to see warnings for both lines, even for config that is not > set, because it maybe we set by a build script depending on USE flags > for instance, so that build target may still refer to non-existent > config. I did not say Ying Sun's patch covered your case. I just meant I dislike your approach. After his patch is applied, please come back with a similar approach if you want to address your case in the mainline kernel. -- Best Regards Masahiro Yamada
