Re: [PATCH v4] kconfig: nconf: Add search jump feature

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 8/8/23 17:42, Jesse Taube wrote:
> From: Jesse Taube <mr.bossman075@xxxxxxxxx>
> 
> Menuconfig has a feature where you can "press the key in the (#) prefix
> to jump directly to that location. You will be returned to the current
> search results after exiting this new menu."
> 
> This commit adds this feature to nconfig, with almost identical code.
> 
> Signed-off-by: Jesse Taube <Mr.Bossman075@xxxxxxxxx>
> ---
> v1->v2:
>  Add selected_conf to go to menu and select a specific option.
>  Use get_line instead of creating new function.
>  Use Masahiro Yamada's new jump search implementation.
> v2->v3:
>  Change `start, end` to size_t and move scope to if
>  Removed redundant assignment of `again` to false.
> v3->v4:
>  Remove unnecessary size_t cast
>  Use ncurses to find line index in selected_conf
> ---
>  scripts/kconfig/nconf.c     | 113 ++++++++++++++++++++++++++++++++----
>  scripts/kconfig/nconf.gui.c |  37 ++++++++++--
>  scripts/kconfig/nconf.h     |   5 ++
>  3 files changed, 140 insertions(+), 15 deletions(-)
> 

I'm not discovering any issues with this version.

Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Tested-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>

Thanks.
-- 
~Randy



[Index of Archives]     [Linux&nblp;USB Development]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite Secrets]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux