On Tue, Aug 1, 2023 at 8:12 PM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote:
>
> On Mon, Jul 31, 2023 at 8:34 AM Jesse Taube <mr.bossman075@xxxxxxxxx> wrote:
> >
> > Menuconfig has a feature where you can "press the key in the (#) prefix
> > to jump directly to that location. You will be returned to the current
> > search results after exiting this new menu."
> >
> > This commit adds this feature to nconfig, with almost identical code.
> >
> > Signed-off-by: Jesse Taube <Mr.Bossman075@xxxxxxxxx>
> > ---
>
>
> Applied to linux-kbuild. Thanks.
I take this back.
As Randy pointed out, this has some flaws.
Please fix the reported problems and submit v4.
> > + if (extra_key_cb) {
> > + size_t start = (size_t)(get_line(text, start_y) - text);
> > + size_t end = (size_t)(get_line(text, start_y + text_lines) - text);
One more request.
I believe the casts '(size_t)' are unneeded here.
Please drop them.
--
Best Regards
Masahiro Yamada
