Re: [PATCH v1] kconfig: Alias mconfig to menuconfig, qconfig to xconfig

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Aug 5, 2023 at 1:38 PM Jesse T <mr.bossman075@xxxxxxxxx> wrote:
>
> On Fri, Aug 4, 2023 at 11:54 PM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
> >
> > Hi,
> >
> > On 8/4/23 20:42, Jesse Taube wrote:
> > > All the other menu-based config tools have a one-letter prefix, and
> > > are named the same as their respective file,
> > > except for mconfig and qconfig. This commit adds an alias for mconfig
> > > to menuconfig and qconfig to xconfig.
> > >
> > > Signed-off-by: Jesse Taube <Mr.Bossman075@xxxxxxxxx>
> > > ---
> > >  scripts/kconfig/Makefile | 6 +++++-
> > >  1 file changed, 5 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile
> > > index af1c96198f49..319cd623acb9 100644
> > > --- a/scripts/kconfig/Makefile
> > > +++ b/scripts/kconfig/Makefile
> >
> > > @@ -45,7 +47,7 @@ PHONY += build_$(1)
> > >  build_$(1): $(obj)/$($(1)-prog)
> > >  endef
> > >
> > > -$(foreach c, config menuconfig nconfig gconfig xconfig, $(eval $(call config_rule,$(c))))
> > > +$(foreach c, config menuconfig mconfig nconfig gconfig xconfig qconfig, $(eval $(call config_rule,$(c))))
> > >
> > >  PHONY += localmodconfig localyesconfig
> > >  localyesconfig localmodconfig: $(obj)/conf
> > > @@ -118,7 +120,9 @@ help:
> > >       @echo  '  config          - Update current config utilising a line-oriented program'
> > >       @echo  '  nconfig         - Update current config utilising a ncurses menu based program'
> > >       @echo  '  menuconfig      - Update current config utilising a menu based program'
> > > +     @echo  '  mconfig         - Alias to menuconfig'
> > >       @echo  '  xconfig         - Update current config utilising a Qt based front-end'
> > > +     @echo  '  qconfig         - Alias to xconfig'
>
> Crap how did I miss this.
> @Masahiro, can you add that when applying?


I am not applying this.

I do not understand why it is useful.




> I'll take a reviewed-by as a yes otherwise I will submit V2 tomorrow.
>
> >
> > Seems to be missing an ending ' mark above... if we need this.
> >
> > >       @echo  '  gconfig         - Update current config utilising a GTK+ based front-end'
> > >       @echo  '  oldconfig       - Update current config utilising a provided .config as base'
> > >       @echo  '  localmodconfig  - Update current config disabling modules not loaded'
> >
> > --
> > ~Randy



--
Best Regards
Masahiro Yamada




[Index of Archives]     [Linux&nblp;USB Development]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite Secrets]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux