On Fri, Jul 21, 2023 at 12:19 PM Bagas Sanjaya <bagasdotme@xxxxxxxxx> wrote: > > Hi, > > I notice a regression report on Bugzilla [1]. Quoting from it: > > > I'm on AMD64 with Debian testing (trixie), where I build my own kernels (with CONFIG_MODULES unset) using "make bindeb-pkg". The build proceeds through 99% of the process, but fails here: > > > > Kernel: arch/x86/boot/bzImage is ready (#2) > > make -f ./Makefile ARCH=x86 KERNELRELEASE=6.4.4-i5 intdeb-pkg > > sh ./scripts/package/builddeb > > *** > > *** The present kernel configuration has modules disabled. > > *** To use the module feature, please run "make menuconfig" etc. > > *** to enable CONFIG_MODULES. > > *** > > make[5]: *** [Makefile:1969: modules_install] Error 1 > > make[4]: *** [scripts/Makefile.package:150: intdeb-pkg] Error 2 > > make[3]: *** [Makefile:1657: intdeb-pkg] Error 2 > > make[2]: *** [debian/rules:16: binary-arch] Error 2 > > dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2 > > make[1]: *** [scripts/Makefile.package:139: bindeb-pkg] Error 2 > > make: *** [Makefile:1657: bindeb-pkg] Error 2 > > > > 6.3.13 contained the same error, but I "fixed" that by moving to 6.4.3. But alas, 6.4.4 now has the same issue. > > > > I worked around the issue by changing "exit 1" to "exit 0" in the main Makefile (at "modules module_install", per the attached patch), but I don't know if this is a true fix or something that simply happens to work for my particular configuration. > > See Bugzilla for the full thread and attached patch that ignores the error. > > Josh: It looks like this regression is caused by a commit of yours > (and also 1240dabe8d58b4). Would you like to take a look on it? > > Anyway, I'm adding this regression to be tracked by regzbot: > > #regzbot introduced: 4243afdb932677 https://bugzilla.kernel.org/show_bug.cgi?id=217689 > #regzbot title: always doing modules_install breaks CONFIG_MODULES=n builds > > Thanks. > > [1]: https://bugzilla.kernel.org/show_bug.cgi?id=217689 > > -- > An old man doll... just what I always wanted! - Clara The following commit must be back-ported. commit 8ae071fc216a25f4f797f33c56857f4dd6b4408e Author: Masahiro Yamada <masahiroy@xxxxxxxxxx> Date: Thu Jun 15 20:17:43 2023 +0900 kbuild: make modules_install copy modules.builtin(.modinfo) -- Best Regards Masahiro Yamada