Re: [PATCH] kbuild: Enable -Wenum-conversion by default

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 6, 2023 at 1:20 AM Nathan Chancellor <nathan@xxxxxxxxxx> wrote:
>
> On Wed, Jul 05, 2023 at 12:19:51AM +0200, Borislav Petkov wrote:
> > From: "Borislav Petkov (AMD)" <bp@xxxxxxxxx>
> >
> > This diagnostic checks whether there is a type mismatch when
> > converting enums (assign an enum of type A to an enum of type B, for
> > example) and it caught a legit issue recently. The reason it didn't show
> > is because that warning is enabled only with -Wextra with GCC. Clang,
> > however, enables it by default.
> >
> > GCC folks were considering enabling it by default but it was too noisy
> > back then:
> >
> >   https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78736
> >
> > Now that due to clang all those warnings have been fixed, enable it with
> > GCC too.
> >
> > allmodconfig tests done with: x86, arm{,64}, powerpc{,64}, riscv
> > crossbuilds.
> >
> > Signed-off-by: Borislav Petkov (AMD) <bp@xxxxxxxxx>
>
> Yes please :)
>
> Reviewed-by: Nathan Chancellor <nathan@xxxxxxxxxx>
>




Applied to linux-kbuild.
Thanks.






-- 
Best Regards
Masahiro Yamada




[Index of Archives]     [Linux&nblp;USB Development]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite Secrets]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux