On Tue, Jun 27, 2023 at 12:08 PM Jesse T <mr.bossman075@xxxxxxxxx> wrote: > > On Mon, Jun 26, 2023 at 8:38 PM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote: > > > > On Sun, Jun 25, 2023 at 5:36 AM Jesse T <mr.bossman075@xxxxxxxxx> wrote: > > > > > > On Sat, Jun 24, 2023 at 4:11 AM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote: > > > > > > > > On Sun, Jun 18, 2023 at 9:16 AM Jesse Taube <mr.bossman075@xxxxxxxxx> wrote: > > > > > > > > > > Menuconfig has a feature where you can "press the key in the (#) prefix > > > > > to jump directly to that location. You will be returned to the current > > > > > search results after exiting this new menu." > > > > > > > > > > This commit adds this feature to nconfig, with almost identical code. > > > > > > > > > > Signed-off-by: Jesse Taube <Mr.Bossman075@xxxxxxxxx> > > > > > > > > > > > > Setting the code duplication aside, > > > > > > > > > If it does function as expected will you accept the patch? > > > > > > Probably. > > > > The menuconfig code you copied is really ugly. > > Yes, I saw and was surprised it was allowed, grandfathered in I guess. Yes, you are grandfathered in. Code refactoring is one of maintainer's jobs. > > > Actually, I was refactoring the search jump code a few > > months ago, but I did not get around to completing it. > > This isn't on git.kernel.org, would you mind sharing it? > If you have any ideas on the best way to implement this, > I would love suggestions. Digging into my local repository, it looks like I had written up functional code already. I just filled in the commit description. I will post it. > Thanks, > Jesse T > > > > > > > > > > > > > > > > > > > > Should I mark the copied codes' original location? > > > > > > > does this patch work correctly? > > > > > > > > > > > > > > > > > > > > $ make defconfig > > > > $ make nconfig > > > > > > > > Press F8 > > > > > > > > Input "MODULES" in the search box. > > > > > > > > You will see: > > > > > > > > (1) -> Enable loadable module support > > > > > > > > Press the "1" key. > > > > > > > > > > > > It will navigate to "General setup" > > > > instead of "Enable loadable module support". > > > > > > > > > Hmm, this is a confusing issue. > > > It will take you to the parent menu of the option, it should move you > > > to the parent option and > > > move the cursor to the option location. I will see if I can resolve > > > this oversight. > > > > > > Thanks, > > > Jesse Taube > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > Best Regards > > > > Masahiro Yamada > > > > > > > > -- > > Best Regards > > Masahiro Yamada -- Best Regards Masahiro Yamada
