On Fri, May 5, 2023 at 7:13 AM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote: > > On Fri, May 5, 2023 at 12:00 AM Ahmed S. Darwish <darwi@xxxxxxxxxxxxx> wrote: > > > > Hi Nathan, > > > > On Thu, 04 May 2023, Nathan Chancellor wrote: > > > > > > On Thu, May 04, 2023 at 10:18:33PM +0200, Ahmed S. Darwish wrote: > > ... > > > > + suffixparams= > > > > + if [ -v O ]; then > > > > > > I think > > > > > > if [ -n "$O" ]; then > > > > > > would match the style preferred by Kbuild (though that is usually for > > > portability sake, which probably does not matter here since bash is > > > explicitly requested). Perhaps not worth addressing if there is no other > > > reason for a v2. > > > > > > > Thanks, I'll do it. I've just discovered that a v2 is necessary anyway. > > > > If O= has a "~", for example as in: > > > > make O=~/build/ gtags > > > > the snippet below: > > > > > > + suffixparams="-C $tree $O" > > > > + fi > > > > + all_target_sources | gtags -i -f - $suffixparams > > ^ > > will fail since the "~" in the O= directory path won't get dereferenced > > before getting passed to the gtags call (an eval is needed). > > > > I'll submit a v2 shortly. > > > > Kind regards, > > > > -- > > Ahmed S. Darwish > > Linutronix GmbH > > > > It is wrong to check whether you are building out of the > source tree. See line 159 of the Makefile. Let me correct this sentense. It is wrong to use 'O' to check whether you are building out of the source tree. -- Best Regards Masahiro Yamada
