Hi Linus, Can you apply this, please? It can probably wait for the merge window if you don't want to apply it now as it only affects building the kernel. Thanks, David --- From: Ekaterina Orlova <vorobushek.ok@xxxxxxxxx> ASN.1: Fix check for strdup() success It seems there is a misprint in the check of strdup() return code that can lead to NULL pointer dereference. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 4520c6a49af8 ("X.509: Add simple ASN.1 grammar compiler") Signed-off-by: Ekaterina Orlova <vorobushek.ok@xxxxxxxxx> Signed-off-by: David Howells <dhowells@xxxxxxxxxx> cc: David Woodhouse <dwmw2@xxxxxxxxxxxxx> cc: James Bottomley <jejb@xxxxxxxxxxxxx> cc: Jarkko Sakkinen <jarkko@xxxxxxxxxx> cc: keyrings@xxxxxxxxxxxxxxx cc: linux-kbuild@xxxxxxxxxxxxxxx Link: https://lore.kernel.org/r/20230315172130.140-1-vorobushek.ok@xxxxxxxxx/ --- scripts/asn1_compiler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/asn1_compiler.c b/scripts/asn1_compiler.c index 7b6756a8c15d..4c3f645065a4 100644 --- a/scripts/asn1_compiler.c +++ b/scripts/asn1_compiler.c @@ -625,7 +625,7 @@ int main(int argc, char **argv) p = strrchr(argv[1], '/'); p = p ? p + 1 : argv[1]; grammar_name = strdup(p); - if (!p) { + if (!grammar_name) { perror(NULL); exit(1); }