On Mon, 2023-04-17 at 23:25 +0900, Masahiro Yamada wrote: > This new target builds only the debian source package. > > Unify the build rules of deb-pkg, srcdeb-pkg, bindeb-pkg to avoid > code duplication. > > Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx> > Reviewed-by: Nicolas Schier <nicolas@xxxxxxxxx> > --- [...] > bindeb-pkg: debian > - +dpkg-buildpackage -r$(KBUILD_PKG_ROOTCMD) -a$$(cat debian/arch) $(DPKG_FLAGS) -b -nc -uc > +deb-pkg srcdeb-pkg bindeb-pkg: > + +$(strip dpkg-buildpackage \ > + --build=$(build-type) --no-pre-clean --unsigned-changes \ > + $(if $(findstring source, $(build-type)), \ > + --unsigned-source) \ > + $(if $(findstring binary, $(build-type)), \ > + -r$(KBUILD_PKG_ROOTCMD) -a$$(cat debian/arch), \ > + --no-check-builddeps) \ [...] There is no need to make the use of --unsigned-source (-us) or -r conditional on the build type. They will be ignored if not applicable. This is also adding --no-check-builddeps (-d), which is not explained in the commit message. It might be valid to add this for srcdeb-pkg, but the build dependency check is valuable for bindeb-pkg and deb-pkg. Ben. -- Ben Hutchings Sturgeon's Law: Ninety percent of everything is crap.
Attachment:
signature.asc
Description: This is a digitally signed message part
