On Mon, Apr 10, 2023 at 07:03:05PM +0900 Masahiro Yamada wrote: [...] > [2] Be careful! > > > While testing the patch submissions of this, > I messed up my repository multiple times. > > The script takes some time because it builds many objects > internally. > > However, once this script starts running, you must not hit Ctrl-C. > If you do it, your repository will be sprinkled with a ton > of untracked files. > > Apply this patch, and run "./scripts/check-uapi.sh -p v6.0" > and hit Ctrl-C. > > Repeat it a couple of times, and "git status" will show you > something horrible. > > > You will never know when git is checking out a commit > because this script hides it by 'git checkout --quiet'. > > > So, this tool should show a caveat at least. > > > 'git checkout' should not be hidden, or > maybe a caveat message should be shown. > > > CAVEAT > This tool runs 'git checkout' a couple of times internally. > If you interrupt it, your worktree might be messed up. John, did you consider using git export for obtaining a source tree that can be used for headers_install and the following comparison, instead of git stash+checkout? AFACS the script does not depend on any other git functionality than providing a specific version of the source tree. I am pretty sure that leaving the original working copy in its original state is supporting the script's popularity. Kind regards, Nicolas
