On Sun, Mar 19, 2023 at 12:21 PM Steev Klimaszewski <steev@xxxxxxxx> wrote: > > Hi Masahiro, > > On Sat, Mar 18, 2023 at 9:19 PM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote: > > > > On Sun, Mar 19, 2023 at 10:12 AM Steev Klimaszewski <steev@xxxxxxxx> wrote: > > > > > > Hi Masahiro, > > > > > > On Sun, Mar 12, 2023 at 1:07 PM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote: > > > > > > > > This series fixes some bugs, then switch to 'git archive' > > > > for source package creation as suggested by Linus. > > > > > > I apologize if this is a stupid question, but it's not immediately apparent to > > > me... > > > > > > Previously, I was overriding the deb file output name by the setting of > > > LOCALVERSION_AUTO; but with this series applied, that seems to be ignored? > > > > > > Now if I pass LOCALVERSION="" I end up with e.g. linux-image-6.3.0-rc2_6.3.0-rc2-00575-g46c71cad996d-100_arm64.deb > > > whereas previously, I would end up with linux-image-6.3.0-rc2_6.3.0-rc2-100_arm64.deb > > > > > > How would I restore the old naming behaviour? > > > > > > -- steev > > > > The same string "6.3.0-rc2" is repeated in the file name. > > The first one is what Debian calls the ABI version, and the > > second one is the version of the package. > > They are usually different on real Debian kernels. > > > > LOCALVERSION affects the former, and KDEB_PKGVERSION > > the second. > > > > > > My recommendation is "just let it be" > > because "linux-upstream_6.3.0-rc2.orig.tar.gz" > > you would generate is not the real 6.3.0-rc2. > > > > > > If you want to restore what you previously did, > > > > make deb-pkg KDEB_PKGVERSION=6.3.0-rc2-100 > > > > will create such a file name. > > > My apologies, my text editor seemed to swallow up half of my previous > email as what I was trying to say wasn't all in there... > What I meant to say is that, prior to this patchset, if > LOCALVERSION_AUTO=y we would end up with > > linux-image-6.3.0-rc2_6.3.0-rc2-00575-g46c71cad996d-100_arm64.deb > > where > LOCALVERSION_AUTO="00575-g46c71cad996d" > NUMBEROFBUILDS="100" (i'm not sure where this number was stored previously) > > Assuming the above 2 are what the current settings are... > > And if you turned LOCALVERSION_AUTO off, and had changes on top of the > git repo, you would end up with > > linux-image-6.3.0-rc2_6.3.0-rc2+-100_arm64.deb > > Then if you would pass LOCALVERSION="", on top of LOCALVERSION_AUTO > being unset, you would end up with > > linux-image-6.3.0-rc2_6.3.0-rc2-100_arm64.deb > > Now with your patchset applied, with LOCALVERSION_AUTO being unset, > you end up with > > linux-image-6.3.0-rc2_6.3.0-rc2-00575-g46c71cad996d-100_arm64.deb > > Which means that LOCALVERSION_AUTO goes away? It did not go away. LOCALVERSION_AUTO is meant to set kernelrelease, which will result in 'uname -r' in the installed system. LOCALVERSION_AUTO should not affect the Debian package version, which is a different thing. > I'm not sure why the > package version overrides what I'm trying to set in the first place in > the kernel config? > > Your workaround is mostly fine, but that "-100" on the end means I > have to now personally track how many builds I've done? "-100" is the build revision, which will go into the .version file while building the kernel. It is not so important, you can set whatever number. If you leave the revision auto-incremented, this is equivalent to what Kbuild is doing internally. make KDEB_PKGVERSION=$(make kernelversion)-$(init/build-version) bindeb-pkg > > > > > > > -- > > Best Regards > > Masahiro Yamada -- Best Regards Masahiro Yamada
