On Tue, Mar 7, 2023 at 4:28 PM Vinay Varma <varmavinaym@xxxxxxxxx> wrote: > > Sorry, got caught up with another project and lost track of this thread. > I have updated the patch and replied to some of the threads inline. No problem -- thanks! Note that we may need a rebase after https://lore.kernel.org/rust-for-linux/20230307120736.75492-1-nmi@xxxxxxxxxxxx/ (or equivalent) lands in `rust-fixes`. So perhaps wait for that, then rebase (especially if we go with the EAFP style), and then others may want to give it a spin for a re-test. When you rebase, please consider putting `f"{name}.o"` inside the function to avoid repetition, and perhaps consider inverting the condition to avoid indenting the file further (and reducing the diff). It makes the "Skip ..." comment more understandable (otherwise, you may want to change the comment to "Only process ..." or similar instead of using "Skip ..."). Cheers, Miguel
