On 3/4/23 10:54, Alexey Dobriyan wrote: > On Sat, Mar 04, 2023 at 09:56:08AM -0800, Randy Dunlap wrote: >> Hi, >> >> On 3/4/23 08:55, Alexey Dobriyan wrote: >>> Menuconfig has lots of vertical space wasted: on my system there are >>> 17 lines of useful information about config options and 14 lines of >>> useless fluff: legend, horizontal separators and shadows. >>> >>> Sitation is even worse on smaller terminals because fixed vertical lines >>> do not go away, but config option lines do decreasing informational >>> density even more. >>> >>> Delete shadows and increase menu size to reclaim vertical space. >>> >>> Signed-off-by: Alexey Dobriyan <adobriyan@xxxxxxxxx> >>> --- >>> >>> scripts/kconfig/lxdialog/checklist.c | 2 -- >>> scripts/kconfig/lxdialog/dialog.h | 1 - >>> scripts/kconfig/lxdialog/inputbox.c | 2 -- >>> scripts/kconfig/lxdialog/menubox.c | 6 ++---- >>> scripts/kconfig/lxdialog/textbox.c | 2 -- >>> scripts/kconfig/lxdialog/util.c | 22 ---------------------- >>> scripts/kconfig/lxdialog/yesno.c | 2 -- >>> 7 files changed, 2 insertions(+), 35 deletions(-) >>> >> >> This patch works for me, but since the right side shadow is >> also being removed, the one column (width) that it had >> occupied might as well be used (reclaimed) instead of just >> going to waste. > > Horizontal space is not really important because monitors are wider > than taller and our config option descriptions are quite short. Yeah, but there is no reason not to reclaim the one horizontal column. This does it for me: (lightly tested) diff -- a/scripts/kconfig/lxdialog/menubox.c b/scripts/kconfig/lxdialog/menubox.c --- a/scripts/kconfig/lxdialog/menubox.c +++ b/scripts/kconfig/lxdialog/menubox.c @@ -184,7 +184,7 @@ do_resize: return -ERRDISPLAYTOOSMALL; height -= 2; - width -= 5; + width -= 4; menu_height = height - 10; We might also be able to reduce the length of menu_instructions[] and put more of it into the other Help text if that interests you. -- ~Randy
