On Mon, Jan 30, 2023 at 8:20 AM Miguel Ojeda <miguel.ojeda.sandonis@xxxxxxxxx> wrote: > > On Sun, Jan 29, 2023 at 7:46 PM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote: > > > > - include init io_uring ipc kernel lib mm net rust \ > > For Rust, it is early to deal with packaging, so removing this from > here should not hurt. I guess you are talking about kernel-devel-*.rpm (and linux-headers-.deb). They are not useful for building external modules written in Rust since they do not contain *.rmeta etc. I am not caring about that because Rust support is not mature enough yet. This series does not touch binary packages, rather it just changes how the source package is created. I stopped hard-coding the top-level directories. The resulting source package still contains all check-in files under rust/, so it is good from the source package perspective. > In any case, I quickly tried the series and noticed that the > `.src.rpm` does not end in the `SRPMS` folder (as it did before) -- is > that expected? 5/5 changed the behavior because rpm-pkg re-uses the *.src.rpm generated by srcrpm-pkg. Having *.src.rpm in the kernel tree seems Redhat's preference. Commit 8818039f959b2efc0d6f2cb101f8061332f0c77e added --define='_srcrpmdir $(srctree)'. In contrast, binary rpm files are generated under rpmbuild/RPMS/. I want to fix this inconsistency, though. -- Best Regards Masahiro Yamada
