Hi Nipun, I love your patch! Yet something to improve: [auto build test ERROR on next-20230127] [cannot apply to masahiroy-kbuild/for-next masahiroy-kbuild/fixes robh/for-next joro-iommu/next linus/master v6.2-rc5 v6.2-rc4 v6.2-rc3 v6.2-rc5] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Nipun-Gupta/cdx-add-the-cdx-bus-driver/20230128-161622 patch link: https://lore.kernel.org/r/20230126104630.15493-6-nipun.gupta%40amd.com patch subject: [PATCH v6 5/7] cdx: add cdx controller config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20230128/202301282010.JreX4WjQ-lkp@xxxxxxxxx/config) compiler: sh4-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/f412d73800370b8e51d1be454e651d3c4ff796a8 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Nipun-Gupta/cdx-add-the-cdx-bus-driver/20230128-161622 git checkout f412d73800370b8e51d1be454e651d3c4ff796a8 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh SHELL=/bin/bash drivers/cdx/controller/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> All error/warnings (new ones prefixed by >>): drivers/cdx/controller/cdx_controller.c: In function 'xlnx_cdx_probe': >> drivers/cdx/controller/cdx_controller.c:102:20: error: implicit declaration of function 'kzalloc' [-Werror=implicit-function-declaration] 102 | cdx_mcdi = kzalloc(sizeof(*cdx_mcdi), GFP_KERNEL); | ^~~~~~~ >> drivers/cdx/controller/cdx_controller.c:102:18: warning: assignment to 'struct cdx_mcdi *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 102 | cdx_mcdi = kzalloc(sizeof(*cdx_mcdi), GFP_KERNEL); | ^ >> drivers/cdx/controller/cdx_controller.c:115:13: warning: assignment to 'struct cdx_controller *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 115 | cdx = kzalloc(sizeof(*cdx), GFP_KERNEL); | ^ >> drivers/cdx/controller/cdx_controller.c:131:9: error: implicit declaration of function 'kfree'; did you mean 'kvfree'? [-Werror=implicit-function-declaration] 131 | kfree(cdx_mcdi); | ^~~~~ | kvfree cc1: some warnings being treated as errors vim +/kzalloc +102 drivers/cdx/controller/cdx_controller.c 95 96 static int xlnx_cdx_probe(struct platform_device *pdev) 97 { 98 struct cdx_controller *cdx; 99 struct cdx_mcdi *cdx_mcdi; 100 int ret; 101 > 102 cdx_mcdi = kzalloc(sizeof(*cdx_mcdi), GFP_KERNEL); 103 if (!cdx_mcdi) 104 return -ENOMEM; 105 106 /* Store the MCDI ops */ 107 cdx_mcdi->mcdi_ops = &mcdi_ops; 108 /* MCDI FW: Initialize the FW path */ 109 ret = cdx_mcdi_init(cdx_mcdi); 110 if (ret) { 111 dev_err_probe(&pdev->dev, ret, "MCDI Initialization failed\n"); 112 goto mcdi_init_fail; 113 } 114 > 115 cdx = kzalloc(sizeof(*cdx), GFP_KERNEL); 116 if (!cdx) { 117 ret = -ENOMEM; 118 goto cdx_alloc_fail; 119 } 120 platform_set_drvdata(pdev, cdx); 121 122 cdx->dev = &pdev->dev; 123 cdx->priv = cdx_mcdi; 124 cdx->ops = &cdx_ops; 125 126 return 0; 127 128 cdx_alloc_fail: 129 cdx_mcdi_finish(cdx_mcdi); 130 mcdi_init_fail: > 131 kfree(cdx_mcdi); 132 133 return ret; 134 } 135 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
