On Wed, Jan 18, 2023 at 8:51 AM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote:
>
> On Wed, Jan 18, 2023 at 4:45 PM Sedat Dilek <sedat.dilek@xxxxxxxxx> wrote:
> >
> > On Mon, Jan 16, 2023 at 4:21 AM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote:
> > >
> > > On Mon, Jan 16, 2023 at 11:02 AM Sedat Dilek <sedat.dilek@xxxxxxxxx> wrote:
> > > >
> > > > Hi Masahiro,
> > > >
> > > > I saw these warnings in my build-log:
> > > >
> > > > if ! command -v sha1sum >/dev/null; then echo "warning: cannot check
> > > > the header due to sha1sum missing"; exit 0; fi; if [ "$(sed -n '$s://
> > > > ::p' include/linux/atomic/
> > > > atomic-arch-fallback.h)" != "$(sed '$d'
> > > > include/linux/atomic/atomic-arch-fallback.h | sha1sum | sed 's/
> > > > .*//')" ]; then echo "error: include/linux/atomic/atomic-arch-f
> > > > allback.h has been modified." >&2; exit 1; fi; touch
> > > > .checked-atomic-arch-fallback.h
> > > > if ! command -v sha1sum >/dev/null; then echo "warning: cannot check
> > > > the header due to sha1sum missing"; exit 0; fi; if [ "$(sed -n '$s://
> > > > ::p' include/linux/atomic/
> > > > atomic-instrumented.h)" != "$(sed '$d'
> > > > include/linux/atomic/atomic-instrumented.h | sha1sum | sed 's/ .*//')"
> > > > ]; then echo "error: include/linux/atomic/atomic-instrume
> > > > nted.h has been modified." >&2; exit 1; fi; touch .checked-atomic-instrumented.h
> > > > if ! command -v sha1sum >/dev/null; then echo "warning: cannot check
> > > > the header due to sha1sum missing"; exit 0; fi; if [ "$(sed -n '$s://
> > > > ::p' include/linux/atomic/
> > > > atomic-long.h)" != "$(sed '$d' include/linux/atomic/atomic-long.h |
> > > > sha1sum | sed 's/ .*//')" ]; then echo "error:
> > > > include/linux/atomic/atomic-long.h has been modified
> > > > ." >&2; exit 1; fi; touch .checked-atomic-long.h
> > > >
> > > > NOTE: I did a `make distclean` before I started my build.
> > > >
> > > > Can you please comment on this?
> > >
> > >
> > >
> > >
> > > Please clarify your problem.
> > >
> > > My best guess is, you just added V=1 option to
> > > print the full log, didn't you?
> > >
> > >
> > >
> > > I can see the same build log by running the following command.
> > >
> >
> > Hi Masahiro,
> >
> > you had a chance to look into this?
>
>
> I already replied.
> This is the output of V=1.
> There is no issue.
>
This due to this change?
commit b10fdeea8cf42c0d97b337e9e501c92da4389a03
"kbuild: check sha1sum just once for each atomic header"
$ LC_ALL=C git blame Kbuild | grep 'warning: cannot check the header
due to sha1sum missing'
b10fdeea8cf42 (Masahiro Yamada 2022-08-20 18:15:29 +0900 51)
echo "warning: cannot check the header due to sha1sum
missing"; \
diff --git a/Kbuild b/Kbuild
index e122d93cee320..0b9e8a16a6212 100644
--- a/Kbuild
+++ b/Kbuild
...
+# Check the manual modification of atomic headers
+
+quiet_cmd_check_sha1 = CHKSHA1 $<
+ cmd_check_sha1 = \
+ if ! command -v sha1sum >/dev/null; then \
+ echo "warning: cannot check the header due to sha1sum missing"; \
+ exit 0; \
+ fi; \
+ if [ "$$(sed -n '$$s:// ::p' $<)" != \
+ "$$(sed '$$d' $< | sha1sum | sed 's/ .*//')" ]; then \
+ echo "error: $< has been modified." >&2; \
+ exit 1; \
+ fi; \
+ touch $@
+
+atomic-checks += $(addprefix $(obj)/.checked-, \
+ atomic-arch-fallback.h \
+ atomic-instrumented.h \
+ atomic-long.h)
+
+targets += $(atomic-checks)
+$(atomic-checks): $(obj)/.checked-%: include/linux/atomic/% FORCE
+ $(call if_changed,check_sha1)
...
Again, what says my make V=1 log-file:
$ grep warning:
6.2.0-rc4-2-amd64-clang15-kcfi/build-log_6.2.0-rc4-2-amd64-clang15-kcfi.txt
222: if ! command -v sha1sum >/dev/null; then echo "warning: cannot
check the header due to sha1sum missing"; exit 0; fi; if [ "$(sed -n
'$s:// ::p' include/linux/atomic/atomic-arch-fallback.h)" != "$(sed
'$d' include/linux/atomic/atomic-arch-fallback.h | sha1sum | sed 's/
.*//')" ]; then echo "error:
include/linux/atomic/atomic-arch-fallback.h has been modified." >&2;
exit 1; fi; touch .checked-atomic-arch-fallback.h
223: if ! command -v sha1sum >/dev/null; then echo "warning: cannot
check the header due to sha1sum missing"; exit 0; fi; if [ "$(sed -n
'$s:// ::p' include/linux/atomic/atomic-instrumented.h)" != "$(sed
'$d' include/linux/atomic/atomic-instrumented.h | sha1sum | sed 's/
.*//')" ]; then echo "error:
include/linux/atomic/atomic-instrumented.h has been modified." >&2;
exit 1; fi; touch .checked-atomic-instrumented.h
224: if ! command -v sha1sum >/dev/null; then echo "warning: cannot
check the header due to sha1sum missing"; exit 0; fi; if [ "$(sed -n
'$s:// ::p' include/linux/atomic/atomic-long.h)" != "$(sed '$d'
include/linux/atomic/atomic-long.h | sha1sum | sed 's/ .*//')" ]; then
echo "error: include/linux/atomic/atomic-long.h has been modified."
>&2; exit 1; fi; touch .checked-atomic-long.h
Does it only say I checked the timestamp and thus created
.checked-$atomic-header-file or does it say I have checked the
timestamp and see there were modifications and thus created
.checked-$atomic-header-file?
Thanks.
[1] https://git.kernel.org/linus/b10fdeea8cf42
>
>
>
> >
> > Thanks.
> >
> > Regards,
> > -Sedat-
> >
> > >
> > > $ make V=1 mrproper defconfig prepare | grep sha1sum
> > > + [ clean = clean ]
> > > + cleanup
> > > + rm -f .btf.*
> > > + rm -f System.map
> > > + rm -f vmlinux
> > > + rm -f vmlinux.map
> > > + exit 0
> > > if ! command -v sha1sum >/dev/null; then echo "warning: cannot check
> > > the header due to sha1sum missing"; exit 0; fi; if [ "$(sed -n '$s://
> > > ::p' include/linux/atomic/atomic-arch-fallback.h)" != "$(sed '$d'
> > > include/linux/atomic/atomic-arch-fallback.h | sha1sum | sed 's/
> > > .*//')" ]; then echo "error:
> > > include/linux/atomic/atomic-arch-fallback.h has been modified." >&2;
> > > exit 1; fi; touch .checked-atomic-arch-fallback.h
> > > if ! command -v sha1sum >/dev/null; then echo "warning: cannot check
> > > the header due to sha1sum missing"; exit 0; fi; if [ "$(sed -n '$s://
> > > ::p' include/linux/atomic/atomic-instrumented.h)" != "$(sed '$d'
> > > include/linux/atomic/atomic-instrumented.h | sha1sum | sed 's/ .*//')"
> > > ]; then echo "error: include/linux/atomic/atomic-instrumented.h has
> > > been modified." >&2; exit 1; fi; touch .checked-atomic-instrumented.h
> > > if ! command -v sha1sum >/dev/null; then echo "warning: cannot check
> > > the header due to sha1sum missing"; exit 0; fi; if [ "$(sed -n '$s://
> > > ::p' include/linux/atomic/atomic-long.h)" != "$(sed '$d'
> > > include/linux/atomic/atomic-long.h | sha1sum | sed 's/ .*//')" ]; then
> > > echo "error: include/linux/atomic/atomic-long.h has been modified."
> > > >&2; exit 1; fi; touch .checked-atomic-long.h
> > >
> > >
> > >
> > >
> > >
> > >
> > > >
> > > > Thanks.
> > > >
> > > > Best regards,
> > > > -Sedat-
> > >
> > >
> > >
> > >
> > > --
> > > Best Regards
> > > Masahiro Yamada
>
>
>
> --
> Best Regards
> Masahiro Yamada
