> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > Sent: Wednesday, January 18, 2023 6:13 PM > To: Gupta, Nipun <Nipun.Gupta@xxxxxxx>; robh+dt@xxxxxxxxxx; > krzysztof.kozlowski+dt@xxxxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; > rafael@xxxxxxxxxx; eric.auger@xxxxxxxxxx; alex.williamson@xxxxxxxxxx; > cohuck@xxxxxxxxxx; song.bao.hua@xxxxxxxxxxxxx; > mchehab+huawei@xxxxxxxxxx; maz@xxxxxxxxxx; f.fainelli@xxxxxxxxx; > jeffrey.l.hugo@xxxxxxxxx; saravanak@xxxxxxxxxx; Michael.Srba@xxxxxxxxx; > mani@xxxxxxxxxx; yishaih@xxxxxxxxxx; jgg@xxxxxxxx; jgg@xxxxxxxxxx; > robin.murphy@xxxxxxx; will@xxxxxxxxxx; joro@xxxxxxxxxx; > masahiroy@xxxxxxxxxx; ndesaulniers@xxxxxxxxxx; linux-arm- > kernel@xxxxxxxxxxxxxxxxxxx; linux-kbuild@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx > Cc: okaya@xxxxxxxxxx; Anand, Harpreet <harpreet.anand@xxxxxxx>; Agarwal, > Nikhil <nikhil.agarwal@xxxxxxx>; Simek, Michal <michal.simek@xxxxxxx>; > git (AMD-Xilinx) <git@xxxxxxx> > Subject: Re: [PATCH 03/19] dt-bindings: bus: add CDX bus controller device tree > bindings (...) > >>> +properties: > >>> + compatible: > >>> + const: xlnx,cdxbus-controller > >> > >> This misses SoC specific compatible. Drop "bus" - redundant. I would > >> also say - drop controller - do you see any other devices with such > >> compatible naming? Use naming consistent with other devices in the > >> kernel. Just open some controllers - SPI, I2C etc. and look there. > > > > Makes sense. Will use "xlnx,cdx" in compatible. > > No, this still misses device specific compatible. You did ignored half > of my comment now. Sorry I missed that part. Will rename this to "xlnx,versal-cdx". Thanks, Nipun > > > Best regards, > Krzysztof
