On Tue, Jan 17, 2023 at 07:11:36PM +0530, Nipun Gupta wrote: > +/** Request/Response structure */ > +#define MCDI_HEADER_OFST 0 > +#define MCDI_HEADER_CODE_LBN 0 > +#define MCDI_HEADER_CODE_WIDTH 7 > +#define MCDI_HEADER_RESYNC_LBN 7 > +#define MCDI_HEADER_RESYNC_WIDTH 1 > +#define MCDI_HEADER_DATALEN_LBN 8 > +#define MCDI_HEADER_DATALEN_WIDTH 8 > +#define MCDI_HEADER_SEQ_LBN 16 > +#define MCDI_HEADER_SEQ_WIDTH 4 > +#define MCDI_HEADER_RSVD_LBN 20 > +#define MCDI_HEADER_RSVD_WIDTH 1 > +#define MCDI_HEADER_NOT_EPOCH_LBN 21 > +#define MCDI_HEADER_NOT_EPOCH_WIDTH 1 > +#define MCDI_HEADER_ERROR_LBN 22 > +#define MCDI_HEADER_ERROR_WIDTH 1 > +#define MCDI_HEADER_RESPONSE_LBN 23 > +#define MCDI_HEADER_RESPONSE_WIDTH 1 > +#define MCDI_HEADER_XFLAGS_LBN 24 > +#define MCDI_HEADER_XFLAGS_WIDTH 8 <snip> This whole file could use some tabs to align all of the values for the defines to make it readable. Any chance of doing that? thanks, greg k-h
