On Tue, Jan 17, 2023 at 05:30:43AM +0000, Thomas Weißschuh wrote:
> If the cpio command is not available the error emitted by
> gen_kheaders.so is not clear as all output of the call to cpio is
> discarded:
>
> GNU make 4.4:
>
> GEN kernel/kheaders_data.tar.xz
> find: 'standard output': Broken pipe
> find: write error
> make[2]: *** [kernel/Makefile:157: kernel/kheaders_data.tar.xz] Error 127
> make[1]: *** [scripts/Makefile.build:504: kernel] Error 2
>
> GNU make < 4.4:
>
> GEN kernel/kheaders_data.tar.xz
> make[2]: *** [kernel/Makefile:157: kernel/kheaders_data.tar.xz] Error 127
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [scripts/Makefile.build:504: kernel] Error 2
>
> Add an explicit check that will trigger a clear message about the issue:
>
> CHK kernel/kheaders_data.tar.xz
> ./kernel/gen_kheaders.sh: line 17: type: cpio: not found
Thanks for the patch! What would you think about an even more verbose
message? Perhaps something like:
echo >&2 ' *** "cpio" is required for "CONFIG_IKHEADERS". >&2
Reviewed-by: Nicolas Schier <n.schier@xxxxxx>
Kind regards,
Nicolas
Attachment:
signature.asc
Description: PGP signature
