On Sat, Dec 31, 2022 at 11:25 PM Miguel Ojeda <miguel.ojeda.sandonis@xxxxxxxxx> wrote: > > On Sat, Dec 31, 2022 at 9:30 AM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote: > > > > scripts/ is a better place to generate files used treewide. > > Agreed, and its generator is in `scripts/` already anyway. > > > You do not need to add target.json to no-clean-files or MRPROER_FILES. > > Maybe adding something like "If moved to `scripts/`, then (...)" would > make the sentence a bit more clear. OK, i will rephrase it in v2. > (Also, typo: `MRPROPER`) > > > -$(obj)/core.o: $(RUST_LIB_SRC)/core/src/lib.rs $(obj)/target.json FORCE > > +$(obj)/core.o: $(RUST_LIB_SRC)/core/src/lib.rs scripts/target.json FORCE > > Should this be `$(srctree)/scripts...` for clarity/consistency? (I see > most instances like that elsewhere too) No. scripts/target.json is a generated file. It is generated in objtree, not in srctree. > Cheers, > Miguel -- Best Regards Masahiro Yamada
