Re: Port silent mode detection to future gnu make.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 29, 2022 at 12:00 PM Dmitry Goncharov
<dgoncharov@xxxxxxxxxxxx> wrote:
>
> Good morning.
>
> On Sun, Nov 27, 2022 at 1:02 AM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote:
> > Please come back after your patch is applied
> > (and please have the patch include the commit hash
> > causing the behaviour change)
>
>
>
> The change is available in git in sha dc2d963989b96161472b2cd38cef5d1f4851ea34.
>
> regards, Dmitry
>
> diff --git a/Makefile b/Makefile
> index 6f846b1f2618..c5d5558e9806 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -94,7 +94,7 @@ endif
>  # If the user is running make -s (silent mode), suppress echoing of
>  # commands
>
> -ifneq ($(findstring s,$(filter-out --%,$(MAKEFLAGS))),)
> +ifneq ($(findstring s,$(firstword -$(MAKEFLAGS))),)
>    quiet=silent_
>    KBUILD_VERBOSE = 0
>  endif



Yup, I saw that.



Paul said with GNU Make 4.4,
Kbuild is already having an issue in the -s detection.


$ export MAKEFLAGS=-I/usr/local/mk

 or

$ export MAKEFLAGS=-Orecurse



Commit 77881d228103 ("Ensure that MAKEFLAGS is set when invoking $(shell ...)")
is the commit that caused a change.


Please send v2 with $(firstword) and updated commit log.



Also, add this tag:

Link: https://lists.gnu.org/archive/html/bug-make/2022-11/msg00190.html



-- 
Best Regards
Masahiro Yamada



[Index of Archives]     [Linux&nblp;USB Development]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite Secrets]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux