Re: [PATCH v2 0/7] Rename DTB overlay source files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 26, 2022 at 09:11:21AM -0500, Rob Herring wrote:
> On Mon, Oct 24, 2022 at 12:34 PM Andrew Davis <afd@xxxxxx> wrote:
> >
> > Hello all,
> >
> > This is a series based on my patch here[0]. As suggested by Rob
> > I've resurrected Frank's patch and appended it to mine as a series.
> >
> > First patch here is my original patch, 3rd is Frank's patch but with
> > the unittest changes pulled out into the 2nd patch. That was re-worked
> > moving the source building macro into scripts/Makefile.lib.
> >
> > Patches 4, 5, and 6 are an attempt at renaming all the existing DTB
> > overlays. Split out by platform so they could be taken by platform
> > maintainers or if easier ACK'd here and taken all together.
> >
> > This should cover all the DTB overlays so we can remove the old .dts
> > rule for overlays and make .dtso the only supported way, let me know
> > if we want that this cycle and I can post that too.
> >
> > Thanks,
> > Andrew
> >
> > Changes from v1[1]:
> >  - Added patch to rename pi433 overlay.
> >  - Cleaned wording on patch 4-6.
> >  - Collected some ACKs
> >
> > [0] https://www.spinics.net/lists/kernel/msg4548509.html
> > [1] https://www.spinics.net/lists/arm-kernel/msg1020165.html
> >
> > Andrew Davis (6):
> >   kbuild: Allow DTB overlays to built from .dtso named source files
> >   kbuild: Allow DTB overlays to built into .dtso.S files
> >   arm64: dts: freescale: Rename DTB overlay source files from .dts to
> >     .dtso
> >   arm64: dts: renesas: Rename DTB overlay source files from .dts to
> >     .dtso
> >   arm64: dts: xilinx: Rename DTB overlay source files from .dts to .dtso
> >   staging: pi433: overlay: Rename overlay source file from .dts to .dtso
> >
> > Frank Rowand (1):
> >   of: overlay: rename overlay source files from .dts to .dtso
> 
> I've applied patches 1-3 and 7. I'll send a PR for the branch to the
> platform maintainers after a few days in linux-next.

The patch

commit 941214a512d8c80d47e720c17ec17e8539175e93
Author: Andrew Davis <afd@xxxxxx>
Date:   Mon Oct 24 12:34:29 2022 -0500

    kbuild: Allow DTB overlays to built into .dtbo.S files

broke the build reproducibility / no-op builds.

Before:
  2+ execution of `make` on non-changed tree did nothing

Now:
  Each run of `make` (even without a single bit changed) restarts vmlinux
  rebuild.

Please, revert or fix.

-- 
With Best Regards,
Andy Shevchenko





[Index of Archives]     [Linux&nblp;USB Development]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite Secrets]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux