On Mon, Sep 12, 2022 at 6:41 PM Zeng Heng <zengheng4@xxxxxxxxxx> wrote:
>
> Remove unused argment 'ch' in sym_set_choice_value
>
> Signed-off-by: Zeng Heng <zengheng4@xxxxxxxxxx>
Can you remove sym_set_choice_value() and
call sym_set_tristate_value(chval, yes) directly?
> ---
> scripts/kconfig/conf.c | 2 +-
> scripts/kconfig/lkc.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c
> index 4178065ca27f..635265a18a07 100644
> --- a/scripts/kconfig/conf.c
> +++ b/scripts/kconfig/conf.c
> @@ -551,7 +551,7 @@ static int conf_choice(struct menu *menu)
> print_help(child);
> continue;
> }
> - sym_set_choice_value(sym, child->sym);
> + sym_set_choice_value(child->sym);
> for (child = child->list; child; child = child->next) {
> indent += 2;
> conf(child);
> diff --git a/scripts/kconfig/lkc.h b/scripts/kconfig/lkc.h
> index fa8c010aa683..279d56a44136 100644
> --- a/scripts/kconfig/lkc.h
> +++ b/scripts/kconfig/lkc.h
> @@ -124,7 +124,7 @@ static inline struct symbol *sym_get_choice_value(struct symbol *sym)
> return (struct symbol *)sym->curr.val;
> }
>
> -static inline bool sym_set_choice_value(struct symbol *ch, struct symbol *chval)
> +static inline bool sym_set_choice_value(struct symbol *chval)
> {
> return sym_set_tristate_value(chval, yes);
> }
> --
> 2.25.1
>
--
Best Regards
Masahiro Yamada
