On Tue, Aug 2, 2022 at 3:16 AM Nathan Chancellor <nathan@xxxxxxxxxx> wrote: > > On Mon, Aug 01, 2022 at 10:40:29AM -0700, Justin Stitt wrote: > > > OK, I think that will be good timing. > > > Please ping me if I forget to pick it up. > > > > > Hey Masahiro, just pinging to see the state of this PR. > > > > I think we are on pace to re-enable this warning. > > > > I believe there exists only _two_ patches left still needing to go > > through along with this patch: > > 1) https://lore.kernel.org/all/20220718050356.227647-1-hch@xxxxxx/ > > This is now in the block tree, so it should be squared away: > > https://lore.kernel.org/YuFhR9OoPvM9VsdT@xxxxxxxxxxxxx/ > > Stephen is on vacation so -next hasn't updated for a few days but it > sounds like Mark is going to provide some coverage: > > https://lore.kernel.org/YugAzWWl++ArhhPS@xxxxxxxxxxxxx/ > > > 2) https://lore.kernel.org/all/YtnDltqEVeJQQkbW@dev-arch.thelio-3990X/ > > We need to chase this, as I haven't seen an "applied" email. We have two > options: > > 1. Ask the maintainers to apply the change to their branch directly. > 2. Ask them for an "Ack" so that we can apply that change along with > this one. > > It is worth a ping asking which they prefer. The first option is > simpler, as the change that introduced the warning is only in -next so > it can just be applied to the same branch; the only concern is making > sure that change makes -rc1. The second option gives us more flexibility > with enabling the warning in the event that the change missed being > added to the main pull request but it will require basing the change on > a non-rc base, which most maintainers don't really like. > > It is ultimately up to Masahiro but my vision is: > > 1. Ping the patch, asking how to proceed. > 2. If the maintainers can pick it up and it will make the merge window, > let them apply it then apply this patch to the Kbuild tree for -next. > 3. If they prefer the "Ack" route, wait until mainline contains the > problematic patch then apply the warning fix patch and this patch to > the Kbuild tree on top of the problematic merge. > 4. Wait until all other patches are in mainline (I can watch mainline > and build it continuously) then pull request the branch containing > whatever changes we need. > > Masahiro, does that sound reasonable? > > Cheers, > Nathan Now applied to linux-kbuild. If my pull request is rejected because of some warnings, I may end up with dropping this, though. -- Best Regards Masahiro Yamada
