On Thu, Jul 21, 2022 at 08:10:27AM -0700, Nathan Chancellor wrote: > On Thu, Jul 21, 2022 at 07:27:34AM -0700, Nick Desaulniers wrote: > > On Wed, Jul 20, 2022 at 4:23 PM Justin Stitt <justinstitt@xxxxxxxxxx> wrote: > > > > > > There's been an ongoing mission to re-enable the -Wformat warning for > > > Clang. A previous attempt at enabling the warning showed that there were > > > many instances of this warning throughout the codebase. The sheer amount > > > of these warnings really polluted builds and thus -Wno-format was added > > > to _temporarily_ toggle them off. > > > > > > After many patches the warning has largely been eradicated for x86, > > > x86_64, arm, and arm64 on a variety of configs. The time to enable the > > > warning has never been better as it seems for the first time we are > > > ahead of them and can now solve them as they appear rather than tackling > > > from a backlog. > > > > > > As to the root cause of this large backlog of warnings, Clang seems to > > > pickup on some more nuanced cases of format warnings caused by implicit > > > integer conversion as well as default argument promotions from > > > printf-like functions. > > > > > > > > > Link: https://github.com/ClangBuiltLinux/linux/issues/378 > > > Suggested-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx> > > > Signed-off-by: Justin Stitt <justinstitt@xxxxxxxxxx> > > > --- > > > Previous attempt: (https://patchwork.kernel.org/project/linux-kbuild/patch/20190201210853.244043-1-jflat@xxxxxxxxxxxx/) > > > > > > Note: > > > For this patch to land on its feet, the plethora of supporting patches that > > > fixed various -Wformat warnings need to be picked up. Thanfully, a lot > > > of them have! > > > > > > Here are the patches still waiting to be picked up: > > > * https://lore.kernel.org/all/20220718230626.1029318-1-justinstitt@xxxxxxxxxx/ > > > * https://lore.kernel.org/all/20220711222919.2043613-1-justinstitt@xxxxxxxxxx/ > > > > Hi Masahiro, Nathan, and Tom, > > What are your thoughts for _when_ in the release cycle this should be > > picked up? I worry that if we don't remove this soon, we will > > backslide, and more -Wformat issues will crop up making removing this > > in the future like digging in sand. Justin has chased down many > > instances of this warning, and I'm happy to help clean up fallout from > > landing this. > > Let me do a series of builds with the two patches above against > next-20220721 to see if there are any instances of this warning across > the less frequently tested architectures then I will review/ack this. Alright, against next-20220721, I applied: * https://lore.kernel.org/20220712204900.660569-1-justinstitt@xxxxxxxxxx/ (applied to net-next, just not in this -next release) * https://lore.kernel.org/20220718230626.1029318-1-justinstitt@xxxxxxxxxx/ (not picked up) * https://lore.kernel.org/20220711222919.2043613-1-justinstitt@xxxxxxxxxx/ (not picked up) I still see the following warnings. I have suggested fixes, which I am happy to send unless Justin wants to. ======================================================================== ARCH=arm allmodconfig: ../drivers/iommu/msm_iommu.c:603:6: error: format specifies type 'unsigned short' but the argument has type 'int' [-Werror,-Wformat] sid); ^~~ ../include/linux/dev_printk.h:146:70: note: expanded from macro 'dev_warn' dev_printk_index_wrap(_dev_warn, KERN_WARNING, dev, dev_fmt(fmt), ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ ../include/linux/dev_printk.h:110:23: note: expanded from macro 'dev_printk_index_wrap' _p_func(dev, fmt, ##__VA_ARGS__); \ ~~~ ^~~~~~~~~~~ 1 error generated. Introduced by commit f78ebca8ff3d ("iommu/msm: Add support for generic master bindings"). diff --git a/drivers/iommu/msm_iommu.c b/drivers/iommu/msm_iommu.c index 428919a474c1..6a24aa804ea3 100644 --- a/drivers/iommu/msm_iommu.c +++ b/drivers/iommu/msm_iommu.c @@ -599,7 +599,7 @@ static int insert_iommu_master(struct device *dev, for (sid = 0; sid < master->num_mids; sid++) if (master->mids[sid] == spec->args[0]) { - dev_warn(dev, "Stream ID 0x%hx repeated; ignoring\n", + dev_warn(dev, "Stream ID 0x%x repeated; ignoring\n", sid); return 0; } ======================================================================== ARCH=hexagon allmodconfig + CONFIG_FRAME_WARN=0: ../drivers/misc/lkdtm/bugs.c:107:3: error: format specifies type 'unsigned long' but the argument has type 'int' [-Werror,-Wformat] REC_STACK_SIZE, recur_count); ^~~~~~~~~~~~~~ ../include/linux/printk.h:537:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ ../include/linux/printk.h:464:60: note: expanded from macro 'printk' #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ ../include/linux/printk.h:436:19: note: expanded from macro 'printk_index_wrap' _p_func(_fmt, ##__VA_ARGS__); \ ~~~~ ^~~~~~~~~~~ ../drivers/misc/lkdtm/bugs.c:32:24: note: expanded from macro 'REC_STACK_SIZE' #define REC_STACK_SIZE (THREAD_SIZE / 8) ^~~~~~~~~~~~~~~~~ 1 error generated. Introduced by commit 24cccab42c41 ("lkdtm/bugs: Adjust recursion test to avoid elision"). diff --git a/drivers/misc/lkdtm/bugs.c b/drivers/misc/lkdtm/bugs.c index 009239ad1d8a..6381255aaecc 100644 --- a/drivers/misc/lkdtm/bugs.c +++ b/drivers/misc/lkdtm/bugs.c @@ -29,7 +29,7 @@ struct lkdtm_list { #if defined(CONFIG_FRAME_WARN) && (CONFIG_FRAME_WARN > 0) #define REC_STACK_SIZE (_AC(CONFIG_FRAME_WARN, UL) / 2) #else -#define REC_STACK_SIZE (THREAD_SIZE / 8) +#define REC_STACK_SIZE ((unsigned long)(THREAD_SIZE / 8)) #endif #define REC_NUM_DEFAULT ((THREAD_SIZE / REC_STACK_SIZE) * 2) ======================================================================== ARCH=arm allmodconfig: ../drivers/nvme/target/auth.c:492:18: error: format specifies type 'unsigned long' but the argument has type 'size_t' (aka 'unsigned int') [-Werror,-Wformat] ctrl->cntlid, ctrl->dh_keysize, buf_size); ^~~~~~~~~~~~~~~~ ../include/linux/printk.h:517:37: note: expanded from macro 'pr_warn' printk(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ ../include/linux/printk.h:464:60: note: expanded from macro 'printk' #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ ../include/linux/printk.h:436:19: note: expanded from macro 'printk_index_wrap' _p_func(_fmt, ##__VA_ARGS__); \ ~~~~ ^~~~~~~~~~~ 1 error generated. Introduced by commit 71ebe3842ebe ("nvmet-auth: Diffie-Hellman key exchange support"). This one is not clang specific and already has a fix pending: https://lore.kernel.org/20220718050356.227647-1-hch@xxxxxx/ ======================================================================== Pretty much every allmodconfig: ../sound/soc/sof/ipc3-topology.c:2343:4: error: format specifies type 'unsigned char' but the argument has type 'int' [-Werror,-Wformat] SOF_ABI_MAJOR, SOF_ABI_MINOR, SOF_ABI_PATCH); ^~~~~~~~~~~~~ ../include/linux/dev_printk.h:150:67: note: expanded from macro 'dev_info' dev_printk_index_wrap(_dev_info, KERN_INFO, dev, dev_fmt(fmt), ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ ../include/linux/dev_printk.h:110:23: note: expanded from macro 'dev_printk_index_wrap' _p_func(dev, fmt, ##__VA_ARGS__); \ ~~~ ^~~~~~~~~~~ ../include/uapi/sound/sof/abi.h:30:23: note: expanded from macro 'SOF_ABI_MAJOR' #define SOF_ABI_MAJOR 3 ^ ../sound/soc/sof/ipc3-topology.c:2343:19: error: format specifies type 'unsigned char' but the argument has type 'int' [-Werror,-Wformat] SOF_ABI_MAJOR, SOF_ABI_MINOR, SOF_ABI_PATCH); ^~~~~~~~~~~~~ ../include/linux/dev_printk.h:150:67: note: expanded from macro 'dev_info' dev_printk_index_wrap(_dev_info, KERN_INFO, dev, dev_fmt(fmt), ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ ../include/linux/dev_printk.h:110:23: note: expanded from macro 'dev_printk_index_wrap' _p_func(dev, fmt, ##__VA_ARGS__); \ ~~~ ^~~~~~~~~~~ ../include/uapi/sound/sof/abi.h:31:23: note: expanded from macro 'SOF_ABI_MINOR' #define SOF_ABI_MINOR 22 ^~ ../sound/soc/sof/ipc3-topology.c:2343:34: error: format specifies type 'unsigned char' but the argument has type 'int' [-Werror,-Wformat] SOF_ABI_MAJOR, SOF_ABI_MINOR, SOF_ABI_PATCH); ^~~~~~~~~~~~~ ../include/linux/dev_printk.h:150:67: note: expanded from macro 'dev_info' dev_printk_index_wrap(_dev_info, KERN_INFO, dev, dev_fmt(fmt), ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ ../include/linux/dev_printk.h:110:23: note: expanded from macro 'dev_printk_index_wrap' _p_func(dev, fmt, ##__VA_ARGS__); \ ~~~ ^~~~~~~~~~~ ../include/uapi/sound/sof/abi.h:32:23: note: expanded from macro 'SOF_ABI_PATCH' #define SOF_ABI_PATCH 0 ^ 3 errors generated. Introduced by commit 323aa1f093e6 ("ASoC: SOF: Add a new IPC op for parsing topology manifest") for little reason it seems? diff --git a/sound/soc/sof/ipc3-topology.c b/sound/soc/sof/ipc3-topology.c index b2cc046b9f60..65923e7a5976 100644 --- a/sound/soc/sof/ipc3-topology.c +++ b/sound/soc/sof/ipc3-topology.c @@ -2338,7 +2338,7 @@ static int sof_ipc3_parse_manifest(struct snd_soc_component *scomp, int index, } dev_info(scomp->dev, - "Topology: ABI %d:%d:%d Kernel ABI %hhu:%hhu:%hhu\n", + "Topology: ABI %d:%d:%d Kernel ABI %d:%d:%d\n", man->priv.data[0], man->priv.data[1], man->priv.data[2], SOF_ABI_MAJOR, SOF_ABI_MINOR, SOF_ABI_PATCH); ======================================================================== I would really like to see patches in flight for these before this patch is accepted but it is really awesome to see how close we are :) Cheers, Nathan
