Re: [PATCH] kbuild: use a pipe rather than process substitution

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 10, 2022 at 11:34:52PM +0200, Alvin Šipraga wrote:
> From: Alvin Šipraga <alsi@xxxxxxxxxxxxxxx>
> 
> Bash process substitution of the form `foo < <(bar)`, as found in
> scripts/check-local-export, can cause issues in chrooted environments
> and with tools such as pseudo. The blamed commit started to cause build
> errors for me when using the Yocto project's devshell environment;
> devshell uses pseudo internally:
> 
> .../scripts/check-local-export: line 51: /dev/fd/63: No such file or directory
> 
> Replace the process substitution with a simple pipe into the while loop.
> This is functionally equivalent and more portable than the former. Note
> that pipefail is enabled so that the script terminates when ${NM} fails.
> 
> Link: https://bugzilla.yoctoproject.org/show_bug.cgi?id=13288
> Fixes: 31cb50b5590f ("kbuild: check static EXPORT_SYMBOL* by script instead of modpost")
> Signed-off-by: Alvin Šipraga <alsi@xxxxxxxxxxxxxxx>

Oops, I forgot to check the linux-kbuild list before sending this patch. I see
that a more robust patch has been posted which addresses a separate issue, but
which also solves the issue I was trying to address:

https://lore.kernel.org/linux-kbuild/20220608011100.486735-1-masahiroy@xxxxxxxxxx/raw

Please ignore this. Thanks!

Kind regards,
Alvin




[Index of Archives]     [Linux&nblp;USB Development]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite Secrets]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux