On Thu, May 05, 2022 at 10:48:55PM +0900 Masahiro Yamada wrote: > On Thu, May 5, 2022 at 4:24 PM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote: > > > > Currently, enum export is tristate, but export_unknown does not make > > sense in any way. > > > > If the symbol name starts with "__ksymtab_", but the section name > > does not start with "___ksymtab+" or "___ksymtab_gpl+", it is not > > an exported symbol. The variable name just happens to start with > > "__ksymtab_". Do not call sym_add_exported() in this case. > > > > __ksymtab_* is internally by EXPORT_SYMBOL(_GPL) but somebody may > > I mean > "... is internally used by ..." Looks good to me; a nice cleanup. Reviewed-by: Nicolas Schier <nicolas@xxxxxxxxx>