On Mon, Apr 25, 2022 at 9:00 PM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote: > > On Tue, Apr 26, 2022 at 3:41 AM Nick Desaulniers > <ndesaulniers@xxxxxxxxxx> wrote: > > > > On Sun, Apr 24, 2022 at 12:09 PM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote: > > > > > > Add a small helper, sym_add_unresolved() to ease the further > > > refactoring. > > > > > > Remove the 'weak' argument from alloc_symbol() because it is sensible > > > only for unresolved symbols. > > > > I did not yet read the rest of the series to see how else your newly > > added helper `sym_add_unresolved` is used. > > Perhaps the callers of `alloc_symbol` should just set the symbol's > > weak member to true if needed, and alloc_symbol can default to setting > > it false (as the memset currently does)? > > > > Then, you don't need the helper, and just `handle_symbol` needs the > > assignment when `ELF_ST_BIND(sym->st_info) == STB_WEAK`? > > > I will change this in the later commit: > https://patchwork.kernel.org/project/linux-kbuild/patch/20220424190811.1678416-11-masahiroy@xxxxxxxxxx/ > > I think this is a good case for a new helper. > > If you look at the entire series, > "allocate a new symbol and connect it to the proper linked list or hash_table" > is consistently done in a helper function. > > > Also, I chose the function name as they look symmetrical. > > sym_add_unresolved() > sym_add_exported() > sym_add_crc() Ok. Reviewed-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx> -- Thanks, ~Nick Desaulniers
