On Thu, Mar 31, 2022 at 3:23 AM FraSharp <f.duca00@xxxxxxxxx> wrote:
>
> From: Francesco Duca <s23265@xxxxxxxx>
>
> * On some systems (e.g. macOS), using commands like 'uname -n' or
> 'hostname' will print something similar to "hostname.domain"
Not only macOS, but also on Linux systems such as Fedora, Debian.
'uname -s' or 'hostname' prints "hostname.domain"
> ("Francescos-Air.fritz.box" for example), which is very annoying.
I do not think so.
> What works instead is 'hostname -s', which will only write hostname
> without the domain ("Francescos-Air" for example),
> but also keep 'uname -n', as some systems as Arch Linux does not have
> 'hostname' as command.
If so, on Arch Linux, will this patch spit
hostname: command not found
error message because "2>/dev/null" is missing ?
And, the intention of this patch is,
print Francescos-Air if the 'hostname -s' command is available,
but Francescos-Air.fritz.box otherwise, correct ?
>
> * This commit is complementary to
> 1e66d50ad3a1dbf0169b14d502be59a4b1213149
> ("kbuild: Use uname for LINUX_COMPILE_HOST detection")
>
> Signed-off-by: Francesco Duca <s23265@xxxxxxxx>
> ---
> scripts/mkcompile_h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/mkcompile_h b/scripts/mkcompile_h
> index ca40a5258..6054e3eee 100755
> --- a/scripts/mkcompile_h
> +++ b/scripts/mkcompile_h
> @@ -34,7 +34,7 @@ else
> LINUX_COMPILE_BY=$KBUILD_BUILD_USER
> fi
> if test -z "$KBUILD_BUILD_HOST"; then
> - LINUX_COMPILE_HOST=`uname -n`
> + LINUX_COMPILE_HOST=$(hostname -s || uname -n)
> else
> LINUX_COMPILE_HOST=$KBUILD_BUILD_HOST
> fi
> --
> 2.32.0 (Apple Git-132)
>
--
Best Regards
Masahiro Yamada
