Re: [masahiroy-kbuild:for-next 3/5] arch/arm/mm/copypage-v4mc.c:70:3: error: implicit declaration of function '__flush_dcache_page' is invalid in C99

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 14, 2022 at 6:19 PM Arnd Bergmann <arnd@xxxxxxxx> wrote:
>
> On Mon, Mar 14, 2022 at 9:06 AM kernel test robot <lkp@xxxxxxxxx> wrote:
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> >
> > All errors (new ones prefixed by >>):
> >
> > >> arch/arm/mm/copypage-v4mc.c:70:3: error: implicit declaration of function '__flush_dcache_page' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
> >                    __flush_dcache_page(page_mapping_file(from), from);
> >                    ^
> >    arch/arm/mm/copypage-v4mc.c:70:3: note: did you mean 'flush_dcache_page'?
> >    arch/arm/include/asm/cacheflush.h:292:13: note: 'flush_dcache_page' declared here
> >    extern void flush_dcache_page(struct page *);
> >                ^
> > >> arch/arm/mm/copypage-v4mc.c:74:2: error: implicit declaration of function 'set_top_pte' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
>
> I checked this, and found that the configuration was already broken,
> what changed is just the
> exact error message that gcc produces, so lkp flags it as a regression.


Agree.

Clang shows a slightly different error message with -std=gnu89/11.



Old error message     (with -std=gnu89):
  implicit declaration of function '__flush_dcache_page'
[-Werror,-Wimplicit-function-declaration]

New error message   (with -std=gnu11)
  implicit declaration of function '__flush_dcache_page' is invalid in
C99 [-Werror,-Wimplicit-function-declaration]



This was already broken before.









> This is a NOMMU StrongARM1100 config, which has been broken for a long time,
> and already have a patch to disallow that configuration because we ran
> into another
> issue with NOMMU classic processors last week.
>
>          Arnd





-- 
Best Regards
Masahiro Yamada



[Index of Archives]     [Linux&nblp;USB Development]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite Secrets]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux