On 13/12/2021 13:47, Boris Kolpackov wrote:
Ariel Marcovitch <arielmarcovitch@xxxxxxxxx> writes:
The format for comment blocks in the second patch is a suggestion. I
realize some people will think the '###' prefix is distasteful. I'm open
to other options as well, I just couldn't think of a better option that
starts with '#', looks different from a menu and can't be confused with
a disabled config.
Maybe instead of decorating the comment, it makes sense to decorate
(and improve, while at it) the menu? Something along these lines:
#-
# Foo
#
CONFIG_FOO=y
# Comment.
# CONFIG_BAR is not defined
#
# Foo
#-
I also don't think a command is likely to confused with disabled option.
I mean that a comment like this - "CONFIG_FOO is not defined" will be
considered by kconfig as a config, rather than a comment. Apart from
this theoretical case which is not really likely to happen, making a
comment only one line and similar to other lines that start with '#'
really decreases the visibility of these comments.
As for the other suggestions, I think a bigger change will be even
harder for people to accept, but I will leave it to the people to decide.
Thanks for the feedback!
- Ariel Marcovitch
